Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate empty repo check in delete branch API #32569

Merged

Conversation

kemzeb
Copy link
Contributor

@kemzeb kemzeb commented Nov 19, 2024

Found while working on #32433.

This branch will never be executed because we have would have already made the same check a couple lines above.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 19, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 19, 2024
@lunny lunny added backport/v1.22 This PR should be backported to Gitea 1.22 and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. backport/v1.22 This PR should be backported to Gitea 1.22 labels Nov 19, 2024
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 19, 2024
@lunny lunny enabled auto-merge (squash) November 19, 2024 19:42
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 19, 2024
@lunny lunny merged commit 355889d into go-gitea:main Nov 20, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 20, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 20, 2024
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Nov 20, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 20, 2024
* giteaofficial/main:
  Remove duplicate empty repo check in delete branch API (go-gitea#32569)
  Optimize installation-page experience (go-gitea#32558)
  Remove unnecessary code (go-gitea#32560)
  Fix a compilation error in the Gitpod environment (go-gitea#32559)
  Use user.FullName in Oauth2 id_token response (go-gitea#32542)
  Fix some places which doesn't repsect org full name setting (go-gitea#32243)
  Refactor push mirror find and add check for updating push mirror (go-gitea#32539)
  Refactor markup render system (go-gitea#32533)
  Refactor find forks and fix possible bugs that weak permissions check (go-gitea#32528)
  Use better name for userinfo structure (go-gitea#32544)
@kemzeb kemzeb deleted the refactor/api-remove-duplicate-empty-repo-check branch November 20, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants